Add saving flag hack to Skeleton and revert reset timing of animation #102026
+51
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
fix-save-reset
branch
from
f008f65 to
42b37b6
Compare
|
It seems that the SkeletonModifier3D base class needs a static flag to determine if it is valid at save time, so I'll work on adding it. |
|
Write when this is ready for review. |
TokageItLab
force-pushed
the
fix-save-reset
branch
from
42b37b6 to
cb70853
Compare
|
Given that the modifier to perform the processing on saving is special case, I have added a virtual method that returns false by default. RetargetModifier is always processed to reflect the reset result in the child skeleton. However, SpringBoneSimulator has its own saving flag because it only needs a partial process which is collision synchronization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the reset timing of Animation and instead add a saving flag to Skeleton3D as in #91495.
For review, check if the following issue occurs again as regression. Maybe we should add static tests later.